Skip to content

Fix var name issue - #753

Closed
jkarni wants to merge 1 commit into
masterfrom
jkarni/fix/tempfilevar
Closed

Fix var name issue#753
jkarni wants to merge 1 commit into
masterfrom
jkarni/fix/tempfilevar

Conversation

@jkarni

@jkarni jkarni commented Aug 20, 2013

Copy link
Copy Markdown

Wrong var name causes django-chunked (> 10MB?) asset upload to fail.

@cahrens

cahrens commented Aug 20, 2013

Copy link
Copy Markdown

Is there a way to add a test for the "chunked" case?

Line 177 and 178 can be removed, and there are a bunch of unused imports in this file (a plug for IntelliJ-- it points out unused variables and imports, including the typo you are fixing).

@jkarni

jkarni commented Aug 20, 2013

Copy link
Copy Markdown
Author

i.e., the blank line and the comment? isn't cleaning up a different PR altogether?

@cahrens

cahrens commented Aug 20, 2013

Copy link
Copy Markdown

I think removing unused local variables and unused imports can be part of this PR. But if you want to do it as a second one, that's fine.

I am speaking about these lines--
thumbnail_content = None
thumbnail_location = None

Definitely would like to see a test that hits the chunking, if feasible.

@cahrens

cahrens commented Aug 20, 2013

Copy link
Copy Markdown

A couple other questions--

  1. Is there a JIRA ticket that goes with this?
  2. Does this need to go out as a hotfix?

@jkarni

jkarni commented Aug 21, 2013

Copy link
Copy Markdown
Author

Moving to PR against release

@jkarni jkarni closed this Aug 21, 2013
@rocha rocha mentioned this pull request Aug 21, 2013
@rocha
rocha deleted the jkarni/fix/tempfilevar branch August 21, 2013 14:59
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…ebug-view

add a debug_request view that prints the request.
itsjeyd referenced this pull request in open-craft/openedx-platform Nov 24, 2016
updated polls xblock version on mcka
caesar2164 added a commit to caesar2164/edx-platform that referenced this pull request Feb 16, 2018
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Jun 19, 2018
…-attempts-fix

Proversity/problem attempts fix
DanielVZ96 referenced this pull request in open-craft/openedx-platform Jan 31, 2024
#753)

This doesn't make metrics-sending *work* under 3.5 (capture_output isn't
supported on that version, for instance) but it does prevent the presence
of the script from breaking instrumented make targets. As long as the
script loads and the main method runs properly under 3.5, try/else blocks
can handle any other incompatibilities.

Some people still use Python 3.5 with devstack, possibly by accident,
even though devstack is supposed to be on 3.8 now.  Much of devstack works
with 3.5, even if requirements can no longer be installed, so someone who
has docker-compose installed externally and doesn't use a virtualenv may
not notice the environment mismatch.

While we'd like people to upgrade to 3.8, the metrics script should at
least not break their workflow in the meantime, since it is optional.

Also: Note python 3.8 requirement in README while I'm at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants